Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[develop] Fix U18 develop build. #994

Merged
merged 3 commits into from
Nov 9, 2020
Merged

[develop] Fix U18 develop build. #994

merged 3 commits into from
Nov 9, 2020

Conversation

scottarnette
Copy link
Contributor

@scottarnette scottarnette commented Nov 6, 2020 •
edited
Loading

Change Description

The Ubuntu 18.04 build was incorrectly building a tag name to use for it's build based on the contract builder image being used:

  • Set back to using default ubuntu-18.04 as IMAGE_TAG.
    • Let's us ensure the correct container exists for unit and toolchain tests as well as community PRs.
  • Check if Buildkite and using Ubuntu 18.04 for build step.
    • If so, explicitly use the contract builder container.
    • Same for integration test steps.

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@scottarnette scottarnette marked this pull request as ready for review November 6, 2020 21:51
kj4ezj
kj4ezj approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@kj4ezj kj4ezj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@scottarnette scottarnette merged commit 6095236 into develop Nov 9, 2020
@scottarnette scottarnette deleted the sa/fix-develop-cicd branch November 9, 2020 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@masaka3620 masaka3620 masaka3620 approved these changes

@kj4ezj kj4ezj kj4ezj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottarnette @masaka3620 @kj4ezj